Tools: Topology: Build development topology sof-ptl-rt721-4ch-allfmt #10310
Conversation
|
Note: To add formats to DMIC need the kernel patch thesofproject/linux#5559 |
singalsu
force-pushed
the
tplg_sdw_add_float_u8
branch
from
bdadf7b to
7ebe860
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for additional PCM audio formats (U8 and FLOAT_LE) to the Intel SoundWire topology configuration by introducing a new PCM_FORMAT_ALL build option. When enabled, the topology supports 5 audio formats instead of the default 3 (S16_LE, S24_LE, S32_LE, U8, FLOAT_LE).
- Introduces
PCM_FORMAT_ALLconfiguration option with default valuefalse - Conditionally adds U8 and FLOAT_LE format support across all relevant audio components
- Adds new development topology target
sof-ptl-rt721-4ch-allfmtwith extended format support enabled
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/topology/topology2/include/common/common_definitions.conf | Defines new PCM_FORMAT_ALL configuration option |
| tools/topology/topology2/platform/intel/sdw-jack-generic.conf | Adds conditional format support for jack audio components |
| tools/topology/topology2/platform/intel/sdw-dmic-generic.conf | Adds conditional format support for SoundWire DMIC components |
| tools/topology/topology2/platform/intel/sdw-amp-generic.conf | Adds conditional format support for SoundWire amplifier components |
| tools/topology/topology2/platform/intel/dmic-generic.conf | Adds conditional format support for generic DMIC components |
| tools/topology/topology2/platform/intel/deep-buffer.conf | Adds conditional format support for deep buffer playback |
| tools/topology/topology2/development/tplg-targets.cmake | Adds new RT721 topology target with all formats enabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ] | ||
| } | ||
| "false" { | ||
| num_output_audio_formats 1 |
There was a problem hiding this comment.
Removed line that sets num_output_audio_formats to 1, but this value is still needed when PCM_FORMAT_ALL is false. The conditional logic should preserve this line in the false branch.
There was a problem hiding this comment.
Wrong. Every output format definition contains now the num_output_audio_formats 1 for PCM_FORMAT_ALL false.
|
@singalsu looks like some indentation update is needed. |
Yep, I wish there would be an emacs mode for topology .conf to make changes like this less effort. |
singalsu
force-pushed
the
tplg_sdw_add_float_u8
branch
from
7ebe860 to
8e78ff8
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This patch adds option to add the float and 8-bit unsigned format to SDW jack playback and capture. The formats are added only if PCM_FORMAT_ALL is set to true. The default value in common_definitions.conf if false. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds option to add float and unsigned 8-bit playback formats to deep buffer if PCM_FORMAT_ALL is set to true. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds option to add float and unsigned 8-bit playback formats to SDW speaker if PCM_FORMAT_ALL is set to true. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds option to add float and unsigned 8-bit capture formats to SDW microphones if PCM_FORMAT_ALL is set to true. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds option to add float and unsigned 8-bit capture formats to PCH DMIC if PCM_FORMAT_ALL is set to true. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch duplicates from production topologies the PTL ALC721 topology into development directory and adds to all PCMs the FLOAT_LE and U8 formats. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
tplg_sdw_add_float_u8
branch
from
8e78ff8 to
f260468
Compare
|
No changes, rebase to restart CI. |
3 participants
No description provided.